Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added touch support #2

Closed
wants to merge 1 commit into from
Closed

added touch support #2

wants to merge 1 commit into from

Conversation

BerniWittmann
Copy link

I noticed, that this lib doesn't support touch events. (e.g. it doesn't work on a tablet)

that's why I added a property touchwhich lets the user enable or disable touch support.

@egoist
Copy link
Owner

egoist commented Jun 29, 2017

Didn't tablet respond to click event?

@BerniWittmann
Copy link
Author

Not in this case.
Links etc. are clickable on a tablet without a problem, but onclick-outside was not working. Maybe it's because the click event was bound to document in document.addEventListener. But this is just a guess.

Feel free to test it, but I can assure, that it was not working before on tablet and afterwards it does

@egoist
Copy link
Owner

egoist commented Jul 4, 2017

I just came across kentor/react-click-outside#4 and they seem to leave this to userland

@BerniWittmann
Copy link
Author

hmh.. also not a nice solution, but okay..
feel free to close, but maybe adding a small note in README (like they did) would be good

@egoist
Copy link
Owner

egoist commented Jul 4, 2017

thanks, done.

@egoist egoist closed this Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BerniWittmann @egoist